Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cert_info beacon to get cert information from local files #54333

Closed
wants to merge 4 commits into from
Closed

add cert_info beacon to get cert information from local files #54333

wants to merge 4 commits into from

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

This PR adds the cert_info beacon in order to get certificate information from local files on a system.

What issues does this PR fix or reference?

N/A

New Behavior

Provides a cert_info beacon in order to read certificates from files on the local filesystem and report that information on the event bus. This information can be used for certificate reporting/renewal workflows.

Tests written?

Yes

Commits signed with GPG?

Yes

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner August 28, 2019 12:28
@ghost ghost requested a review from cmcmarrow August 28, 2019 12:29
@nicholasmhughes
Copy link
Collaborator Author

Anything else needed here?

@waynew
Copy link
Contributor

waynew commented Oct 4, 2019

Hey @nicholasmhughes thanks for the PR! I noticed that you have a few open - this should apply to them all. I believe that you're aware of our requirement for tests on PRs and I'm know at least several, if not all of your PRs already have those, so 👍

We've recently changed to a single-branch release strategy. What does that mean for your PRs?

We will be porting merged and unmerged PRs from non-master branches to master, prioritized based on their impact to the community (e.g. bug fixes first). You can do nothing and at some future point we'll get these ported to master. Or if you'd like to move things along, you can rebase each of your PRs against master, force push to your fork, and then edit the PR to point towards master (just click the edit button in the top right).

If you have any issues with any of those things, feel free to reach out for assistance. Otherwise... looking forward to getting your PRs merged into master!

@nicholasmhughes nicholasmhughes changed the base branch from develop to master October 5, 2019 21:20
@nicholasmhughes nicholasmhughes changed the base branch from master to develop October 5, 2019 21:21
@nicholasmhughes
Copy link
Collaborator Author

moving to #54902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasp eliasp eliasp left review comments

@waynew waynew waynew approved these changes

@cmcmarrow cmcmarrow Awaiting requested review from cmcmarrow

Assignees
No one assigned
Labels
Awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicholasmhughes @waynew @eliasp @garethgreenaway